irony Work Item Rss Feed

Commented Unassigned: crash with rv null in ComputeProductionFlags [9881]

brantheman — Fri, 26 Apr 2013 19:58:15 GMT

I got the crash (shown in the attached screenshot).
Comments: I think you'll have to fix both Op_Plus and Op_Pipe to handle null inputs.

Commented Unassigned: crash with rv null in ComputeProductionFlags [9881]

rivantsov — Fri, 26 Apr 2013 17:27:43 GMT

I got the crash (shown in the attached screenshot).
Comments: yeah, I see the problem. I think the best place to add this is in overload of "+" operator. Will add in the next code update thanks Roman

Commented Unassigned: crash with rv null in ComputeProductionFlags [9881]

brantheman — Thu, 25 Apr 2013 21:15:54 GMT

I got the crash (shown in the attached screenshot).
Comments: I find that there was a problem in my code. I was using the |= operator on a rule that had not been initialized. It would be nice if that case was handled appropriately. The | operator should return the non-null item out of two.

Commented Unassigned: crash with rv null in ComputeProductionFlags [9881]

brantheman — Thu, 25 Apr 2013 21:10:21 GMT

I got the crash (shown in the attached screenshot).
Comments: At the point of the crash the parent CreateProduction lvalue = {StartSectionRow.grp1}

Commented Unassigned: crash with rv null in ComputeProductionFlags [9881]

brantheman — Thu, 25 Apr 2013 21:08:20 GMT

I got the crash (shown in the attached screenshot).
Comments: I've attached my grammar also.

Created Unassigned: crash with rv null in ComputeProductionFlags [9881]

brantheman — Thu, 25 Apr 2013 21:05:26 GMT

I got the crash (shown in the attached screenshot).

Closed Issue: Possible issue with Scope.GetParent() [9880]

rivantsov — Fri, 05 Apr 2013 06:15:12 GMT

Is there some reason for the implementation of `Irony.Interpreter.Scope.GetParent()` starting to return null for long evaluations? I find that replacing the final `return null` with `return Creator` works fine for me. This is the _my_ workable version:

```
protected Scope GetParent() {
// Walk along creators chain and find a scope with ScopeInfo matching this.ScopeInfo.Parent
var parentScopeInfo = Info.Parent;
if (parentScopeInfo == null)
return null;
var current = Creator;
while (current != null) {
if (current.Info == parentScopeInfo)
return current;
current = current.Creator;
}
return Creator;
//return null;
}// method
```

I am fixing or missing something here?

I implemented merge sort in my lang, and for lists 1 to 4 items long works fine, for anything bigger than that, the previous function starts to return nulls. With the fix, I can sort bigger lists (I tested up to 16 elements..., gonna run more tests when I can).

__Some background__

My lang (https://github.com/fabriceleal/Multitasks) executes each expression in a separate .NET-Thread (as soon as I hit this problem, I rewrote it so it now runs on a single .NET-Thread), so I create a new `ScriptThread` for the evaluation of each expression. The code I'm using for creating a new `ScriptThread` is this (am I doing this ok? I had to peek at the source, I was unable to find up-to-date info on how to do this):

```
// current is the current ScriptThread at the time of evaluation
// _this is an AstNode
var subthread = new ScriptThread(current.App);
var localScopeInfo = new ScopeInfo(_this, true);

_this.DependentScopeInfo = localScopeInfo;

subthread.CurrentScope = current.CurrentScope;
subthread.PushClosureScope(localScopeInfo, subthread.CurrentScope, new object[] { });
subthread.CurrentNode = _this;

return subthread;
```

Expressions can be piped, so the environment must follow, hence the `ClosureScope ` stuff.
Comments: explained in comment

Commented Issue: Possible issue with Scope.GetParent() [9880]

fabriceleal — Tue, 02 Apr 2013 19:38:29 GMT

Commented Issue: Possible issue with Scope.GetParent() [9880]

rivantsov — Tue, 02 Apr 2013 05:49:11 GMT

Edited Issue: Possible issue with Scope.GetParent() [9880]

fabriceleal — Sun, 31 Mar 2013 22:46:21 GMT

Created Issue: Possible issue with Scope.GetParent() [9880]

fabriceleal — Sun, 31 Mar 2013 22:44:12 GMT

Is there some reason for the implementation of `Irony.Interpreter.Scope.GetParent()` starting to return null for long evaluations? I find that replacing the final `return null` with `return Creator` works fine for me. This is the _my_ workable version:

```
protected Scope GetParent() {
// Walk along creators chain and find a scope with ScopeInfo matching this.ScopeInfo.Parent
var parentScopeInfo = Info.Parent;
if (parentScopeInfo == null)
return null;
var current = Creator;
while (current != null) {
if (current.Info == parentScopeInfo)
return current;
current = current.Creator;
}
return Creator;
//return null;
}// method
```

I am fixing or missing something here?

I implemented merge sort in my lang, and for lists 1 to 4 items long works fine, for anything bigger than that, the previous function starts to return nulls. With the fix, I can sort bigger lists (I tested up to 16 elements..., gonna run more tests when I can).

__Some background__

My lang (https://github.com/fabriceleal/Multitasks) executes each expression in a separate .NET-Thread (as soon as I hit this problem, I rewrote it so it now runs on a single .NET-Thread), so I create a new `ScriptThread` for the evaluation of each expression. The code I'm using for creating a new `ScriptThread` is this (_I'm doing this ok? I had to peek at the source, I was unable to find up-to-date info on how to do this_):

```
// current is the current ScriptThread at the time of evaluation
// _this is an AstNode
var subthread = new ScriptThread(current.App);
var localScopeInfo = new ScopeInfo(_this, true);

_this.DependentScopeInfo = localScopeInfo;

subthread.CurrentScope = current.CurrentScope;
subthread.PushClosureScope(localScopeInfo, subthread.CurrentScope, new object[] { });
subthread.CurrentNode = _this;

return subthread;
```

Expressions can be piped, so the environment must follow, hence the `ClosureScope ` stuff.

Closed Issue: Bug in Irony.Interpreter.LanguageRuntime [9873]

rivantsov — Tue, 26 Feb 2013 05:18:43 GMT

Hi Roman,

Maybe I am doing something less than perfectly, but when creating an Ast tree I encountered null values in the BindingRequest.FromModule that caused an unhandled exception and failed Ast build

To reproduce
1) Create a language inheriting Grammar
2) Set the LanguageFlags = LanguageFlags.CreateAst; in the Grammar
3) Override BuildAst in the custom grammar with

public override void BuildAst(LanguageData language, ParseTree parseTree)
{
if (!LanguageFlags.IsSet(LanguageFlags.CreateAst))
return;

var astContext = new InterpreterAstContext(language);
var astBuilder = new AstBuilder(astContext);
astBuilder.BuildAst(parseTree);
}

To fix

I added a condition to Interpreter/LanguageRuntime/LanguageRuntime_Binding.cs that request.FromModule was not null, then the AstTree was created correctly

//3. Check external module imports
if (request.FromModule != null)
{
foreach (var imp in request.FromModule.Imports)
{
var result = imp.Bind(request);
if (result != null)
return result;
}
}

Closed Issue: GrammarExplorer ReflectionTypeLoadException [9865]

rivantsov — Tue, 26 Feb 2013 05:17:52 GMT

In GrammarExplorer if you try to load project dll that has dependencies

fmSelectGrammars.LoadGrammars methopd will throw exception on line 84
types = asm.GetTypes();

To fix it we need to change line 73 from
asm = Assembly.Load(File.ReadAllBytes(assemblyPath));
to
asm = Assembly.LoadFrom(assemblyPath);

Hope it will save time

OD.
Comments: fixed

Closed Issue: Assembly.LoadFrom is still required [9867]

rivantsov — Tue, 26 Feb 2013 05:16:54 GMT

I've just updated to the version 54d64b40c923 and the problem with GrammarLoader failing to find and load dependent assemblies is still there (it throws a ReflectionTypeLoadException when you call GetTypes()).

Changing GrammarLoader.LoadAssembly() from Load(byte[]) to LoadFrom(filename) is still a workaround but it naturally destroys the reloading logic.

Comments: fixed, as much it can be fixed

Closed Issue: AstNodes are a struggle [9868]

rivantsov — Tue, 26 Feb 2013 05:16:24 GMT

Hmm. After a great start, I'm afraid to say that I am thinking of abandoning Irony as it is just too much effort to work with it in its current form.

I'm trying to create a simple AST from my grammar. This is proving to be a real struggle. When I Google for help, I see about ten different answers, none of which work because they are more than a few months out of date and the design seems to change that quickly.

This is sad, because I feel that a small amount of effort spent on *simple* tutorials would make life so much easier for newbies like me. I definitely do not want to wade through the impressive but horrifically complicated samples, I want a simple but *working* definition of how to build an AST for a basic (three-line?) grammar. It's not as if an AST is an esoteric requirement, after all!

Fighting my way through the example expression grammar stuff (because there's a lot of ancilliary "noise" that is relevant to the sample but only serves to complicate it as as a tutorial), I eventually gave up and decided just to step through the code, to see what happens.

What happened was that it crashed inside BuildAst with a null pointer reference. The code in that location says:

//We know that either NodeCreator or DefaultNodeCreator is set; VerifyAstData create the DefaultNodeCreator

which was patently not true.

I have noticed a lot of requests for help in this area, so please would you spend 30 minutes giving a simple example of how it works without all the extra "noise" of a full working application? I'm not stupid but I really don't want to learn the core of all of the library just to create an AST from my grammar. If I did that, I might as well write the whole thing myself!

Thanks!

Dan

Comments: not a real issue, just a complaint

Closed Issue: FastColoredTextBox in GrammarExplorer [9869]

rivantsov — Tue, 26 Feb 2013 05:15:40 GMT

I've recently found a great syntax-highlighting textbox component for WinForms, FastColoredTextBox.
It's actively developed and supported by its single author, Pavel Torgashov:
http://www.codeproject.com/Articles/161871/Fast-Colored-TextBox-for-syntax-highlighting

Roman has asked for help integrating this control to the GrammarExplorer.
>PS. I don't mind if somebody else takes over this effort, not the original author.

I've already tried looking into it, seems like it should be easy to do.
I'll integrate FCTB and push the code to my IronyContrib branch.
Comments: FastColoredTextBox is used in Grammar Explorer now

Closed Issue: ParsingContext.Culture should be used when retrieving error message [9871]

rivantsov — Tue, 26 Feb 2013 05:15:02 GMT

I was willing to translate errors message when I noticed a major bug (at least for us) !

Changing Resources.Culture in constructor of ParsingContext is way too early (therefore almost completely useless) since several grammar using different culture can be instantiated before being actually used for parsing (latest instance always win with current implementation).

REM: This has nothing to do with multi-threading mentioned in the code comments, as it is also fully affect single threaded application.

Resources.Culture should be changed just before accessing the resource (for eg: in OnValidateToken) or even better to also evolve toward solving multi-threading issues by refining custom methods (to preserve strong typing) such as:

/// <summary>
/// Convert a lambda expression as property name
/// </summary>
/// <typeparam name="T"></typeparam>
/// <param name="expression"></param>
/// <returns></returns>
private static string ConvertAsPropertyName<T>(Expression<Func<T>> expression)
{
if (expression == null)
{
throw new ArgumentNullException("expression");
}

var body = expression.Body as MemberExpression;
if (body == null)
{
throw new ArgumentException("Lambda expression must return a property");
}

return body.Member.Name;
}

private string LookupResource(Expression<Func<string>> resourceNameExpr)
{
string resourceName = ConvertAsPropertyName(resourceNameExpr);
return Resources.ResourceManager.GetString(resourceName, this.Culture);
}

public Token CreateErrorToken(Expression<Func<string>> resourceNameExpr, params object[] args) {
string propertyName = LookupResource(resourceNameExpr);

string message = "";

if (args != null && args.Length > 0)
message = string.Format(message, args);
return Source.CreateToken(Language.Grammar.SyntaxError, message);
}

Call later becomes for example:
context.CurrentToken = context.CreateErrorToken(() => Resources.ErrNoLetterAfterNum);

For now I'm not implementing the suggested fix (too much work that is outside my project) and I will try to quickly dirty fix it otherwise to move on :/
Comments: no easy fix for now - for supporting multiple languages at the same time (in one app). Will look at this in new version

Closed Issue: SpecialFormNode.cs code broken (missing) [9872]

rivantsov — Tue, 26 Feb 2013 05:08:50 GMT

Hi Roman,

First a thank you for this great software.

Second, the class SpecialFormNode has broken (missing) c# code.

To reproduce:
Browse Interpreter/Ast/Statements/SpecialFormNode.cs
Search for "context.Language."

The broken code can be seen in the snippet below, context.Language. ends abruptly

public override void Init(AstContext context, ParseTreeNode treeNode) {
base.Init(context, treeNode);
var nodes = treeNode.GetMappedChildNodes();
TargetRef = AddChild("Target", nodes[0]);
TargetRef.UseType = NodeUseType.CallTarget;
_targetName = nodes[0].FindTokenAndGetText();
Arguments = AddChild("Args", nodes[1]);
AsString = "Call " + _targetName;
context.Language.
}
Comments: fixed

Commented Issue: SpecialFormNode.cs code broken (missing) [9872]

rivantsov — Tue, 26 Feb 2013 05:08:42 GMT

Closed Issue: Exclude FirstChars and Suffixes from IsWhitespaceOrDelimiter [9875]

rivantsov — Tue, 26 Feb 2013 05:07:49 GMT

I updated Irony recently in a project and it break compatibility with this kind of terminal:

var columnVariable = new IdentifierTerminal(NodeType.ColumnVariable);
columnVariable.AllFirstChars = "[";
columnVariable.AddSuffix("]", TypeCode.String);

[identifier] or {identifier} // the suffix is optional

I had to override IsWhiteSpaceOrDelimiter and exclude '{', '}', '[', ']' to make it work again,
I guess it could be fixed by exluding these chars in the IsWhiteSpaceOrDelimiter (or perhaps disable QuickParse for Terminals who have WhitespaceOrDelimiters in their syntax, not sure it would work).
Comments: code fix declined, workaround suggested